ASF GitHub Bot commented on NIFI-1526:

Github user markap14 commented on a diff in the pull request:

    --- Diff: 
    @@ -0,0 +1,42 @@
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.nifi.annotation.configuration;
    +import java.lang.annotation.Documented;
    +import java.lang.annotation.Target;
    +import java.lang.annotation.Retention;
    +import java.lang.annotation.ElementType;
    +import java.lang.annotation.RetentionPolicy;
    +import java.lang.annotation.Inherited;
    +import org.apache.nifi.logging.LogLevel;
    + * <p>
    + * Marker interface that a Processor can use to configure the yield 
duration, the  penalty duration and the bulletin log level.
    + * Note that the number of Concurrent tasks will be ignored if the 
annotion @TriggerSerialy is used
    + * </p>
    + */
    +public @interface DefaultSettings {
    +    String yieldDuration() default "1 sec";
    +    String penaltyDuration() default "30 sec";
    +    LogLevel logLevel() default LogLevel.WARN;
    --- End diff --
    This should probably be called bulletinLevel, rather than logLevel. The 
processor can log at any level it wants - this controls which level is shown as 
a bulletin.

> Allow components to provide default values for Yield Duration and Run Schedule
> ------------------------------------------------------------------------------
>                 Key: NIFI-1526
>                 URL: https://issues.apache.org/jira/browse/NIFI-1526
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Bryan Bende
>            Priority: Minor
> It would be nice for developers of processors (and maybe reporting tasks and 
> controller services) to be able to specify a default value for Yield duration 
> and Run Schedule.
> Currently Yield defaults to 1 second and Run Schedule defaults to 0 seconds. 
> There may be cases where these are not the best default values and the 
> developer wants to start off with better defaults, still allowing the user to 
> tune as needed.

This message was sent by Atlassian JIRA

Reply via email to