lordgamez commented on a change in pull request #1069:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1069#discussion_r633276351
##########
File path: libminifi/test/KamikazeProcessor.h
##########
@@ -33,14 +35,14 @@ namespace minifi {
namespace processors {
// GenerateFlowFile Class
class KamikazeProcessor : public core::Processor {
-public:
+ public:
static const std::string OnScheduleExceptionStr;
static const std::string OnTriggerExceptionStr;
static const std::string OnScheduleLogStr;
static const std::string OnTriggerLogStr;
static const std::string OnUnScheduleLogStr;
- KamikazeProcessor(const std::string& name, const utils::Identifier& uuid =
{})
+ explicit KamikazeProcessor(const std::string& name, const utils::Identifier
uuid = utils::Identifier())
Review comment:
Why was the const ref changed here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
