exceptionfactory commented on a change in pull request #5068:
URL: https://github.com/apache/nifi/pull/5068#discussion_r634607962
##########
File path: nifi-docker/dockermaven/sh/start.sh
##########
@@ -33,15 +33,29 @@ if [ ! -z "${NIFI_JVM_DEBUGGER}" ]; then
fi
# Establish baseline properties
-prop_replace 'nifi.web.http.port' "${NIFI_WEB_HTTP_PORT:-8080}"
-prop_replace 'nifi.web.http.host'
"${NIFI_WEB_HTTP_HOST:-$HOSTNAME}"
+prop_replace 'nifi.web.https.port' "${NIFI_WEB_HTTPS_PORT:-8443}"
+prop_replace 'nifi.web.https.host'
"${NIFI_WEB_HTTPS_HOST:-$HOSTNAME}"
prop_replace 'nifi.remote.input.host'
"${NIFI_REMOTE_INPUT_HOST:-$HOSTNAME}"
prop_replace 'nifi.remote.input.socket.port'
"${NIFI_REMOTE_INPUT_SOCKET_PORT:-10000}"
-prop_replace 'nifi.remote.input.secure' 'false'
+prop_replace 'nifi.remote.input.secure' 'true'
# Set nifi-toolkit properties files and baseUrl
"${scripts_dir}/toolkit.sh"
-prop_replace 'baseUrl'
"http://${NIFI_WEB_HTTP_HOST:-$HOSTNAME}:${NIFI_WEB_HTTP_PORT:-8080}";
${nifi_toolkit_props_file}
+prop_replace 'baseUrl'
"https://${NIFI_WEB_HTTPS_HOST:-$HOSTNAME}:${NIFI_WEB_HTTPS_PORT:-8443}";
${nifi_toolkit_props_file}
+
+if [ ! -z "${NIFI_WEB_HTTP_PORT}" ]; then
+ prop_replace 'nifi.web.https.port' ''
+ prop_replace 'nifi.web.https.host' ''
+ prop_replace 'nifi.web.http.port'
"${NIFI_WEB_HTTP_PORT}"
+ prop_replace 'nifi.web.http.host'
"${NIFI_WEB_HTTP_HOST:-$HOSTNAME}"
+ prop_replace 'nifi.remote.input.secure' 'false'
Review comment:
Thanks again @ChrisSamo632, I appreciate the thorough review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
