szaszm commented on a change in pull request #1080:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1080#discussion_r637186528
##########
File path: msi/WixWin.wsi
##########
@@ -395,6 +371,23 @@ Licensed to the Apache Software Foundation (ASF) under one
or more
EventMessageFile="[#MiNiFiExeWithPassword]"
/>
<Condition><![CDATA[SERVICEACCOUNT<>"LocalSystem"]]></Condition>
</Component>
+
+ <Component Id="VSRedistributableFiles"
Guid="7923f16d-785a-41cb-aa74-17e0fa5f1314">
+ <File Id="MiNiFiExe_concrt140" Name="concrt140.dll"
KeyPath="no" Source="redist\concrt140.dll"/>
+ <File Id="MiNiFiExe_msvcp140" Name="msvcp140.dll" KeyPath="no"
Source="redist\msvcp140.dll"/>
+ <File Id="MiNiFiExe_msvcp140_1" Name="msvcp140_1.dll"
KeyPath="no" Source="redist\msvcp140_1.dll"/>
+ <File Id="MiNiFiExe_msvcp140_2" Name="msvcp140_2.dll"
KeyPath="no" Source="redist\msvcp140_2.dll"/>
+ <File Id="MiNiFiExe_vccorlib140" Name="vccorlib140.dll"
KeyPath="no" Source="redist\vccorlib140.dll"/>
+ <File Id="MiNiFiExe_vcruntime140" Name="vcruntime140.dll"
KeyPath="no" Source="redist\vcruntime140.dll"/>
+ <?if $(env.VisualStudioVersion) = 16.0 ?>
+ <File Id="MiNiFiExe_msvcp140_atomic_wait"
Name="msvcp140_atomic_wait.dll" KeyPath="no"
Source="redist\msvcp140_atomic_wait.dll"/>
+ <File Id="MiNiFiExe_msvcp140_codecvt_ids"
Name="msvcp140_codecvt_ids.dll" KeyPath="no"
Source="redist\msvcp140_codecvt_ids.dll"/>
+ <?if $(env.build_platform) = x64 ?>
+ <File Id="MiNiFiExe_vcruntime140_1"
Name="vcruntime140_1.dll" KeyPath="no" Source="redist\vcruntime140_1.dll"/>
+ <?endif ?>
Review comment:
Why did you remove vcruntime140_1.dll from 32bit builds? I couldn't find
a description of individual DLLs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
