pgyori commented on pull request #5090: URL: https://github.com/apache/nifi/pull/5090#issuecomment-847832598
Thank you for approving, @gresockj ! I did not measure the difference in performance. I assume that creating a new instance of a GenericRecord type has some overhead. The other type inheriting from AvroRecordReader (AvroReaderWithEmbeddedSchema) has been using this approach for years ( https://github.com/apache/nifi/blob/7fe8858d22f580ad9dcd96ebafb59dbe5e73f5cb/nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/avro/AvroReaderWithEmbeddedSchema.java#L53 ). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
