exceptionfactory commented on a change in pull request #5065:
URL: https://github.com/apache/nifi/pull/5065#discussion_r638788427
##########
File path:
nifi-registry/nifi-registry-core/nifi-registry-web-ui/src/main/package.json
##########
@@ -0,0 +1,149 @@
+{
+ "//-01": "Licensed to the Apache Software Foundation (ASF) under one or
more",
+ "//-02": "contributor license agreements. See the NOTICE file distributed
with",
+ "//-03": "this work for additional information regarding copyright
ownership.",
+ "//-04": "The ASF licenses this file to You under the Apache License,
Version 2.0",
+ "//-05": "(the \"License\"); you may not use this file except in
compliance with",
+ "//-06": "the License. You may obtain a copy of the License at",
+ "//-07": "",
+ "//-08": "http://www.apache.org/licenses/LICENSE-2.0";,
+ "//-09": "",
+ "//-10": "Unless required by applicable law or agreed to in writing,
software",
+ "//-11": "distributed under the License is distributed on an \"AS IS\"
BASIS,",
+ "//-12": "WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
implied.",
+ "//-13": "See the License for the specific language governing permissions
and",
+ "//-14": "limitations under the License.",
+ "name": "nifi-registry",
+ "version": "0.0.5-SNAPSHOT",
+ "description": "",
+ "scripts": {
+ "start": "npm run watch",
+ "test": "karma start karma.conf.js --single-run",
+ "test:dev": "karma start karma.conf.js",
+ "eslint": "./node_modules/.bin/eslint './webapp/**/*.js'",
+ "eslint:fix": "./node_modules/.bin/eslint './webapp/**/*.js' --fix",
+ "stylelint": "./node_modules/.bin/stylelint
'./webapp/theming/**/*.scss'",
+ "lint": "npm run eslint && npm run stylelint",
+ "lint:production": "../../target/frontend-working-directory/node/node
../../target/frontend-working-directory/node/node_modules/npm/bin/npm-cli.js
run eslint --scripts-prepend-node-path &&
../../target/frontend-working-directory/node/node
../../target/frontend-working-directory/node/node_modules/npm/bin/npm-cli.js
run stylelint --scripts-prepend-node-path",
+ "build:webapp:bundle:development": "npm run webpack:development",
+ "build:webapp:bundle:production":
"../../target/frontend-working-directory/node/node
../../target/frontend-working-directory/node/node_modules/npm/bin/npm-cli.js
run lint:production && ../../target/frontend-working-directory/node/node
../../target/frontend-working-directory/node/node_modules/npm/bin/npm-cli.js
run webpack:production",
+ "webpack:development": "./node_modules/.bin/webpack --config
webpack.dev.js",
+ "webpack:production": "./node_modules/.bin/webpack --config
webpack.prod.js",
+ "watch": "npm run webpack:development &&
./node_modules/.bin/webpack-dev-server --config webpack.dev.js",
+ "lint-staged": "./node_modules/.bin/lint-staged",
+ "preinstall": "../../target/frontend-working-directory/node/node
../../target/frontend-working-directory/node/node_modules/npm/bin/npm-cli.js
--ignore-scripts install npm-force-resolutions &&
../../target/frontend-working-directory/node_modules/.bin/npm-force-resolutions"
+ },
+ "license": "Apache-2.0",
+ "husky": {
+ "hooks": {
+ "pre-commit": "lint-staged"
+ }
+ },
+ "lint-staged": {
+ "*.{js,jsx,ts,tsx}": "eslint",
+ "*.css": "stylelint",
+ "*.scss": "stylelint --syntax=scss"
+ },
Review comment:
Removing these blocks along with husky from the `dependencies` section
should avoid adding the Git hooks.
##########
File path:
nifi-registry/nifi-registry-core/nifi-registry-web-ui/src/main/package.json
##########
@@ -0,0 +1,149 @@
+{
+ "//-01": "Licensed to the Apache Software Foundation (ASF) under one or
more",
+ "//-02": "contributor license agreements. See the NOTICE file distributed
with",
+ "//-03": "this work for additional information regarding copyright
ownership.",
+ "//-04": "The ASF licenses this file to You under the Apache License,
Version 2.0",
+ "//-05": "(the \"License\"); you may not use this file except in
compliance with",
+ "//-06": "the License. You may obtain a copy of the License at",
+ "//-07": "",
+ "//-08": "http://www.apache.org/licenses/LICENSE-2.0";,
+ "//-09": "",
+ "//-10": "Unless required by applicable law or agreed to in writing,
software",
+ "//-11": "distributed under the License is distributed on an \"AS IS\"
BASIS,",
+ "//-12": "WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
implied.",
+ "//-13": "See the License for the specific language governing permissions
and",
+ "//-14": "limitations under the License.",
+ "name": "nifi-registry",
+ "version": "0.0.5-SNAPSHOT",
+ "description": "",
+ "scripts": {
+ "start": "npm run watch",
+ "test": "karma start karma.conf.js --single-run",
+ "test:dev": "karma start karma.conf.js",
+ "eslint": "./node_modules/.bin/eslint './webapp/**/*.js'",
+ "eslint:fix": "./node_modules/.bin/eslint './webapp/**/*.js' --fix",
+ "stylelint": "./node_modules/.bin/stylelint
'./webapp/theming/**/*.scss'",
+ "lint": "npm run eslint && npm run stylelint",
+ "lint:production": "../../target/frontend-working-directory/node/node
../../target/frontend-working-directory/node/node_modules/npm/bin/npm-cli.js
run eslint --scripts-prepend-node-path &&
../../target/frontend-working-directory/node/node
../../target/frontend-working-directory/node/node_modules/npm/bin/npm-cli.js
run stylelint --scripts-prepend-node-path",
+ "build:webapp:bundle:development": "npm run webpack:development",
+ "build:webapp:bundle:production":
"../../target/frontend-working-directory/node/node
../../target/frontend-working-directory/node/node_modules/npm/bin/npm-cli.js
run lint:production && ../../target/frontend-working-directory/node/node
../../target/frontend-working-directory/node/node_modules/npm/bin/npm-cli.js
run webpack:production",
+ "webpack:development": "./node_modules/.bin/webpack --config
webpack.dev.js",
+ "webpack:production": "./node_modules/.bin/webpack --config
webpack.prod.js",
+ "watch": "npm run webpack:development &&
./node_modules/.bin/webpack-dev-server --config webpack.dev.js",
+ "lint-staged": "./node_modules/.bin/lint-staged",
+ "preinstall": "../../target/frontend-working-directory/node/node
../../target/frontend-working-directory/node/node_modules/npm/bin/npm-cli.js
--ignore-scripts install npm-force-resolutions &&
../../target/frontend-working-directory/node_modules/.bin/npm-force-resolutions"
+ },
+ "license": "Apache-2.0",
+ "husky": {
+ "hooks": {
+ "pre-commit": "lint-staged"
+ }
+ },
+ "lint-staged": {
+ "*.{js,jsx,ts,tsx}": "eslint",
+ "*.css": "stylelint",
+ "*.scss": "stylelint --syntax=scss"
+ },
+ "keywords": [],
+ "author": "",
+ "repository": {
+ "type": "git",
+ "url": "https://github.com/apache/nifi-registry";
+ },
+ "dependencies": {
+ "@angular/animations": "8.1.1",
+ "@angular/cdk": "8.1.0",
+ "@angular/common": "8.1.1",
+ "@angular/compiler": "8.1.1",
+ "@angular/core": "8.1.1",
+ "@angular/flex-layout": "8.0.0-beta.26",
+ "@angular/forms": "8.1.1",
+ "@angular/http": "8.0.0-beta.10",
+ "@angular/material": "8.1.1",
+ "@angular/platform-browser": "8.1.1",
+ "@angular/platform-browser-dynamic": "8.1.1",
+ "@angular/router": "8.1.1",
+ "@covalent/core": "2.1.0",
+ "@nifi-fds/core": "0.2.0",
+ "angular2-jwt": "0.2.3",
+ "angular2-moment": "1.9.0",
+ "font-awesome": "4.7.0",
+ "hammerjs": "2.0.8",
+ "jquery": "3.5.1",
+ "material-design-icons": "3.0.1",
+ "moment": "2.22.1",
+ "npm-force-resolutions": "0.0.3",
+ "querystring": "0.2.0",
+ "reset-css": "4.0.1",
+ "roboto-fontface": "0.10.0",
+ "rxjs": "6.5.2",
+ "superagent": "3.8.3",
+ "tslib": "1.8.0",
+ "zone.js": "0.9.0"
+ },
+ "devDependencies": {
+ "@babel/core": "7.4.4",
+ "@babel/preset-env": "7.4.4",
+ "@babel/runtime": "7.4.4",
+ "@typescript-eslint/eslint-plugin": "1.6.0",
+ "babel-loader": "8.0.5",
+ "babel-plugin-istanbul": "5.1.4",
+ "babel-polyfill": "6.26.0",
+ "cache-loader": "3.0.0",
+ "compression-webpack-plugin": "3.0.1",
+ "css-loader": "2.1.1",
+ "dtsgenerator": "2.0.6",
+ "eslint": "5.14.1",
+ "eslint-config-airbnb": "17.1.0",
+ "eslint-plugin-import": "2.16.0",
+ "eslint-plugin-jsx-a11y": "6.2.1",
+ "eslint-plugin-react": "7.12.4",
+ "file-loader": "3.0.1",
+ "html-loader": "0.5.5",
+ "html-webpack-plugin": "3.2.0",
+ "husky": "2.3.0",
Review comment:
Removing this line will eliminate the husky dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
