szaszm commented on a change in pull request #1081:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1081#discussion_r638890480
##########
File path: extensions/pdh/PerformanceDataMonitor.cpp
##########
@@ -45,9 +45,15 @@ core::Property PerformanceDataMonitor::CustomPDHCounters(
core::Property PerformanceDataMonitor::OutputFormatProperty(
core::PropertyBuilder::createProperty("Output Format")->
withDescription("Format of the created flowfiles")->
- withAllowableValue<std::string>(JSON_FORMAT_STR)->
- withAllowableValue(OPEN_TELEMETRY_FORMAT_STR)->
- withDefaultValue(JSON_FORMAT_STR)->build());
+ withAllowableValue(PRETTY_JSON_FORMAT_STR)->
+ withAllowableValue(COMPACT_JSON_FORMAT_STR)->
+ withAllowableValue(PRETTY_OPEN_TELEMETRY_FORMAT_STR)->
+ withAllowableValue(COMPACT_OPEN_TELEMETRY_FORMAT_STR)->
+ withDefaultValue(PRETTY_JSON_FORMAT_STR)->build());
+
+core::Property PerformanceDataMonitor::DoublePrecisionProperty(
+ core::PropertyBuilder::createProperty("Double Precision")->
+ withDescription("Rounds the double values to this precision (blank for
maximum precision)")->build());
Review comment:
What does precision mean in this context? Some power of 10 decimal
place? Or power of 2? Or number of significant decimal digits? Or ...
This could use some more precise description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
