fgerlits commented on a change in pull request #1082:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1082#discussion_r640430620
##########
File path: PROCESSORS.md
##########
@@ -704,6 +704,10 @@ In the list below, the names of required properties appear
in bold. Any other pr
| Name | Description |
| - | - |
|success|All files are routed to success|
Review comment:
I think this could be clarified, eg. `All incoming FlowFiles are routed,
unchanged, to succes`
##########
File path: extensions/librdkafka/tests/ConsumeKafkaTests.cpp
##########
@@ -422,7 +422,7 @@ class ConsumeKafkaContinuousPublishingTest : public
ConsumeKafkaTest {
int64_t value;
org::apache::nifi::minifi::core::TimeUnit unit;
REQUIRE(org::apache::nifi::minifi::core::Property::StringToTime(property_string,
value, unit));
- int64_t value_as_ms;
+ int64_t value_as_ms = 0;
Review comment:
this should be in a different pull request, as it is not related to this
change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
