szaszm commented on a change in pull request #1028:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1028#discussion_r640755085
##########
File path: libminifi/include/io/Stream.h
##########
@@ -24,14 +24,23 @@ namespace nifi {
namespace minifi {
namespace io {
+inline bool isError(const size_t read_return) noexcept {
+ return read_return == static_cast<size_t>(-1) // general error
+ || read_return == static_cast<size_t>(-2); // Socket EAGAIN, to be
refactored to eliminate this error condition
Review comment:
Introduced `constexpr auto minifi::io::STREAM_ERROR =
static_cast<size_t>(-1);` in 47358cb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
