[GitHub] [nifi] BioQwer commented on a change in pull request #5057: NIFI-8338 NIFI-7997 NIFI-6266 fix ftp using proxy bug

Mon, 31 May 2021 05:19:16 -0700 


BioQwer commented on a change in pull request #5057:
URL: https://github.com/apache/nifi/pull/5057#discussion_r642446145



##########
File path: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/FTPTransfer.java
##########
@@ -606,7 +606,7 @@ private FTPClient getClient(final FlowFile flowFile) throws 
IOException {
             client.setAutodetectUTF8(useUtf8Encoding);
         }
 
-        client.connect(inetAddress, 
ctx.getProperty(PORT).evaluateAttributeExpressions(flowFile).asInteger());
+        client.connect(remoteHostName, 
ctx.getProperty(PORT).evaluateAttributeExpressions(flowFile).asInteger());

Review comment:
       @joewitt thanks for answer.
   
   Can you remember, why are you did resolving `inetAddress`? 
   As i see in blame it's your code.
   
![image](https://user-images.githubusercontent.com/5636129/120192155-81aa5600-c223-11eb-9f28-a255a03b153d.png)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to