tpalfy commented on a change in pull request #5109:
URL: https://github.com/apache/nifi/pull/5109#discussion_r642559297



##########
File path: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/util/SnippetUtils.java
##########
@@ -235,41 +236,24 @@ public FlowSnippetDTO populateFlowSnippet(final Snippet 
snippet, final boolean r
 
         // add any process groups
         final ProcessGroupDTO highestProcessGroupDTO = 
dtoFactory.createProcessGroupDto(processGroup, recurse);
-        final Set<ProcessGroupDTO> processGroups = 
highestProcessGroupDTO.getContents().getProcessGroups();
         fillContentsByGroupMap(highestProcessGroupDTO, contentsByGroup);

Review comment:
       This would probably result in an error if a selected group refers to a 
controller service that is in an unselected group because that foreign 
controller service wouldn't inherit the id of the highest process group but 
would retain that of the unselected group.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to