ASF GitHub Bot commented on NIFI-1710:

GitHub user trixpan opened a pull request:


    NIFI-1710 - Resolve path name to nifi.sh script

    ## Description:
    This commit allows nifi.sh to recursively traverse its path, allowing the 
simple linkage of nifi.sh to a script within /etc/init.d/ , therefore 
minimising the number of changes outside NIFI_HOME, required to implement a 
NIFI node.
    Fixes: NIFI-1710
    Closes #315 
    ## PR Checklist:
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.
    - [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
    - [x] Is your initial contribution a single, squashed commit?
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [x] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
    - [x] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
    - [x] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/trixpan/nifi NIFI-1710v2

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1137
commit d3a05ec86fe55800de4b27e7e8a1efc48d8c8259
Author: Andre F de Miranda <trix...@users.noreply.github.com>
Date:   2016-10-14T03:36:48Z

    NIFI-1710 - Resolve path name to nifi.sh script


> Resolve path name to nifi.sh in start script
> --------------------------------------------
>                 Key: NIFI-1710
>                 URL: https://issues.apache.org/jira/browse/NIFI-1710
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Joey Frazee
>            Priority: Trivial
> Currently if you symlink to nifi.sh the start script will not work because $0 
> doesn't evaluate to the physical location and the script assumes 
> bootstrap.conf is relative to the script.
> This means you can't, for example, symlink nifi.sh to /etc/init.d and use the 
> respective service commands to control NiFi.
> Adding realpath or readlink to the script should fix this.

This message was sent by Atlassian JIRA

Reply via email to