Github user simplesteph commented on the issue:
https://github.com/apache/nifi/pull/1136
Hi,
I understand the concern. The tests were passing on my end, but maybe
something has been broken.
Let me explain the rationale:
1) Your API should comply with the OpenAPI specs as you're using swagger
and date-time (see
https://github.com/OAI/OpenAPI-Specification/blob/master/versions/2.0.md). A
datetime looks like this:
https://xml2rfc.tools.ietf.org/public/rfc/html/rfc3339.html#anchor14. Example:
1985-04-12T23:20:50.52Z or 1996-12-19T16:39:57-08:00. Knowing this,
two solutions: either you rename your variable to "string" (and then the
expectations are set), or if you keep date-time, you need to merge my changes.
2) Regarding the UI: in my PR, I chosen to have timestamps with zones,
meaning the timestamp will be adapted from where the NiFi instance is running
(so not UTC). That's a good first step. The second step is to have the UI
website format the date it's receiving from the now-valid REST API, and that's
probably something we may want to add in this PR, or in a separate one. FYI- I
have tested the UI and things aren't broken as far as I can see
3) For breaking the existing clients: which clients are you talking about?
Looking forward to reading from you
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
