lordgamez commented on a change in pull request #1073:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1073#discussion_r645489479
##########
File path: libminifi/include/utils/StringUtils.h
##########
@@ -137,6 +137,7 @@ class StringUtils {
static std::vector<std::string> split(const std::string &str, const
std::string &delimiter);
static std::vector<std::string> splitAndTrim(const std::string &str, const
std::string &delimiter);
+ static std::vector<std::string> splitAndTrimOnString(std::string str, const
std::string& delimiter);
Review comment:
`splitAndTrim` only uses the first character of the given string as a
delimiter, so it actually is using a character as a delimiter not a string. I'm
not sure if that should be updated to have a character as an input delimiter
and keep 2 overloads or the functions should be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
