exceptionfactory commented on a change in pull request #5119:
URL: https://github.com/apache/nifi/pull/5119#discussion_r645561156
##########
File path:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/test/java/org/apache/nifi/services/azure/storage/TestADLSCredentialsControllerService.java
##########
@@ -327,6 +327,28 @@ public void testGetCredentialsDetailsWithSasToken() throws
Exception {
assertNull(actual.getServicePrincipalClientSecret());
}
+ @Test
+ public void testGetCredentialsDetailsWithSasTokenUsingEL() throws
Exception {
+ // GIVEN
+ configureAccountName();
+ configureSasTokenUsingEL();
+
+ runner.enableControllerService(credentialsService);
+
+ // WHEN
+ ADLSCredentialsDetails actual =
credentialsService.getCredentialsDetails(new HashMap<>());
+
+ // THEN
Review comment:
Although a few tests include the given/when/then comments, I recommend
avoiding them for new tests. If there are no other changes, then it is fine to
leave them in place, but otherwise I think it would be better to avoid the
comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
