martinzink commented on pull request #1098:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1098#issuecomment-855721065
> I thought you were going to replace occurrences of
`${PROJECT_VERSION_MAJOR}.${PROJECT_VERSION_MINOR}.${PROJECT_VERSION_PATCH}`
with `${PROJECT_VERSION}`, which would solve the original issue without forcing
an upgrade to CMake 3.16. Did that plan fail?
Yeah, that didnt fail. I just found out that all of our targets use newer
cmake anyways.
Except for debian but were using this backported (3.16 version) prior to
#1093 as well.
I still think that we could use the PROJECT_VERSION variable exclusively but
not sure if leaving these separate variables inconsistent is a good idea in the
long term (maybe some tool uses them?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
