martinzink commented on a change in pull request #1028:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1028#discussion_r647219084
##########
File path: extensions/standard-processors/processors/PutFile.cpp
##########
@@ -304,9 +306,9 @@ void PutFile::getDirectoryPermissions(core::ProcessContext
*context) {
}
#endif
-PutFile::ReadCallback::ReadCallback(const std::string &tmp_file, const
std::string &dest_file)
- : tmp_file_(tmp_file),
- dest_file_(dest_file) {
+PutFile::ReadCallback::ReadCallback(std::string tmp_file, std::string
dest_file)
+ : tmp_file_(std::move(tmp_file)),
+ dest_file_(std::move(dest_file)) {
Review comment:
same question here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
