timeabarna commented on a change in pull request #5136:
URL: https://github.com/apache/nifi/pull/5136#discussion_r647991025
##########
File path:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/eventhub/ConsumeAzureEventHub.java
##########
@@ -91,7 +91,8 @@
})
public class ConsumeAzureEventHub extends AbstractSessionFactoryProcessor {
- private static final String FORMAT_STORAGE_CONNECTION_STRING =
"DefaultEndpointsProtocol=https;AccountName=%s;AccountKey=%s";
+ private static final String
FORMAT_STORAGE_CONNECTION_STRING_FOR_ACCOUNT_KEY =
"DefaultEndpointsProtocol=https;AccountName=%s;AccountKey=%s";
+ private static final String FORMAT_STORAGE_CONNECTION_STRING_FOR_SAS_TOKEN
= "BlobEndpoint=https://%s.blob.core.windows.net/;SharedAccessSignature=%s";;
Review comment:
@jfrazee At the moment ConsumeAzureEventHub processor does not support
special regions, so this is why it is not included in this PR. During
AzureCheckpointLeaseManager initialisation CloudStorageAccount is created by
the parse(storageConnectionString). Parse is using tryConfigureServiceAccount()
method to instantiate CloudStrageAccount using public
CloudStorageAccount(StorageCredentials storageCredentials, StorageUri
blobStorageUri, StorageUri queueStorageUri, StorageUri tableStorageUri,
StorageUri fileStorageUri) constructor. This constructor sets endPointSuffix to
null and as we are not having endpointSuffix in our connectionStrings the url
always be "core windows.net"
It is a good idea though and can be added by a separate request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
