lordgamez commented on a change in pull request #1076:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1076#discussion_r648049916
##########
File path: extensions/librdkafka/ConsumeKafka.cpp
##########
@@ -78,7 +78,8 @@ core::Property
ConsumeKafka::TopicNames(core::PropertyBuilder::createProperty("T
->build());
core::Property
ConsumeKafka::TopicNameFormat(core::PropertyBuilder::createProperty("Topic Name
Format")
- ->withDescription("Specifies whether the Topic(s) provided are a comma
separated list of names or a single regular expression.")
+ ->withDescription("Specifies whether the Topic(s) provided are a comma
separated list of names or a single regular expression. "
+ "Using regular expressions does not automatically discover kafka topics
created after the processor started.")
Review comment:
Update in cdb014f306f614bfad5e6120f089ab821c904677
##########
File path: docker/test/integration/minifi/validators/NumFileRangeValidator.py
##########
@@ -0,0 +1,24 @@
+import logging
+import os
+
+from .FileOutputValidator import FileOutputValidator
+
+
+class NumFileRangeValidator(FileOutputValidator):
+
+ def __init__(self, min_files, max_files):
+ self.valid = False
+ self.min_files = min_files
+ self.max_files = max_files
+
+ def validate(self):
+ self.valid = False
+ full_dir = os.path.join(self.output_dir)
+ logging.info("Output folder: %s", full_dir)
+
+ if not os.path.isdir(full_dir):
+ return self.valid
+
+ num_files = self.get_num_files(full_dir)
+ self.valid = self.min_files < num_files and num_files < self.max_files
+ return self.valid
Review comment:
Update in cdb014f306f614bfad5e6120f089ab821c904677
##########
File path: docker/test/integration/minifi/validators/NoFileOutPutValidator.py
##########
@@ -12,15 +11,13 @@ class NoFileOutPutValidator(FileOutputValidator):
def __init__(self):
self.valid = False
- def validate(self, dir=''):
-
- if self.valid:
- return True
-
- full_dir = self.output_dir + dir
+ def validate(self):
+ self.valid = False
+ full_dir = os.path.join(self.output_dir)
logging.info("Output folder: %s", full_dir)
- listing = listdir(full_dir)
- self.valid = not bool(listing)
+ if not os.path.isdir(full_dir):
+ return self.valid
+ self.valid = (0 == self.get_num_files(full_dir))
return self.valid
Review comment:
Update in cdb014f306f614bfad5e6120f089ab821c904677
##########
File path: docker/test/integration/minifi/processors/GetFile.py
##########
@@ -7,7 +7,7 @@ def __init__(self, input_dir="/tmp/input",
schedule={'scheduling period': '2 sec
'GetFile',
properties={
'Input Directory': input_dir,
- 'Keep Source File': 'true'
+ 'Keep Source File': 'false'
Review comment:
Update in cdb014f306f614bfad5e6120f089ab821c904677
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
