ASF GitHub Bot commented on NIFI-2819:

Github user olegz commented on a diff in the pull request:

    --- Diff: 
    @@ -66,13 +66,15 @@
                 .defaultValue("0 B")
    +            .expressionLanguageSupported(true)
         public static final PropertyDescriptor END_OFFSET = new 
                 .name("End Offset")
    --- End diff --
    When I saw _end-offset_  i got confused since the next offset is the end 
offset, but description states its _Number of bytes removed at the end of the 
file_. This means it's not an offset at all.
    I know this is not part of the immediate issue, but at least consider 
raising an improvement JIRA where this could be fixed. Obviously we can't 
change the _name_, so we'll keep it, but we can add _displayProperty(..)_

> Improve ModifyBytes (Add expression language support)
> -----------------------------------------------------
>                 Key: NIFI-2819
>                 URL: https://issues.apache.org/jira/browse/NIFI-2819
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>    Affects Versions: 1.0.0
>            Reporter: n h
>            Assignee: Matt Burgess
>             Fix For: 1.1.0
> Add expression language support to "Start Offset" and "End Offset" 

This message was sent by Atlassian JIRA

Reply via email to