fgerlits commented on a change in pull request #1097:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1097#discussion_r649207289
##########
File path: extensions/http-curl/client/HTTPClient.cpp
##########
@@ -261,7 +260,7 @@ bool HTTPClient::submit() {
progress_.reset();
curl_easy_setopt(http_session_, CURLOPT_NOPROGRESS, 0);
curl_easy_setopt(http_session_, CURLOPT_XFERINFOFUNCTION, onProgress);
- curl_easy_setopt(http_session_, CURLOPT_XFERINFODATA, (void*)this);
+ curl_easy_setopt(http_session_, CURLOPT_XFERINFODATA,
reinterpret_cast<void*>(this));
Review comment:
The cast is not needed, `this` can be implicitly converted to `void*`.
```suggestion
curl_easy_setopt(http_session_, CURLOPT_XFERINFODATA, this);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
