Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1088#discussion_r83463726
--- Diff:
nifi-nar-bundles/nifi-avro-bundle/nifi-avro-processors/src/main/java/org/apache/nifi/processors/avro/SplitAvro.java
---
@@ -267,7 +267,8 @@ public void process(InputStream rawIn) throws
IOException {
}
// while records are left, start a new split by
spawning a FlowFile
- while (reader.hasNext()) {
+ final AtomicReference<Boolean> hasNextHolder = new
AtomicReference<Boolean>(reader.hasNext());
--- End diff --
I think instead of introducing AtomicReference we can make it a bit lighter
by simply changing the inner loop to be a _do/while_ loop
```
. . .
int recordCount = 0;
do {
recordHolder.set(reader.next(recordHolder.get()));
splitWriter.write(recordHolder.get());
recordCount++;
} while (reader.hasNext() && recordCount < splitSize);
. . .
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
