exceptionfactory opened a new pull request #5152:
URL: https://github.com/apache/nifi/pull/5152
#### Description of PR
NIFI-7468 Resolves several issues with `SSLSocketChannel` handshake
processing in order to work with TLS 1.3.
`SSLSocketChannel` includes custom handling of `javax.net.ssl.SSLEngine`,
which did not respond properly to Post-Handshake Messages in TLS 1.3, described
in RFC 8446 Section 4.6. The `SSLSocketChannel.connect()` method was clearing
stream and application buffers after completing the TLS handshake, resulting in
the loss of Post-Handshake messages as well as network packets. This loss of
data resulted in exceptions such `Tag mismatch` under both TLS 1.2 and TLS 1.3
when using AES-GCM cipher suites.
The `SSLSocketChannelSender.close()` method was also closing the connected
`SocketChannel`, resulting in `SSLSocketChannel` being unable to process TLS
close notify messages.
NIFI-7468 introduces a private `ChannelStatus` enum and convenience logging
methods to support detailed logging at the `TRACE` level when necessary. Logs
and exception messages now include both the remote address and remote port
number to improve troubleshooting options.
The new `SSLSocketChannelTest` leverages a TLS server and client using the
Netty framework to verify expected behavior for both TLS 1.2 and 1.3. Unit
testing and runtime testing of TLS 1.3 requires either Java 11, or a version of
Java 8 with update 272 or higher.
These changes address issues with several processors, including as
`ListenTCP` and `PutTCP`, as well as Distributed Cache Clients running with TLS.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically `main`)?
- [X] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [X] Have you written or updated unit tests to verify your changes?
- [X] Have you verified that the full build is successful on JDK 8?
- [X] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for
build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
