exceptionfactory commented on a change in pull request #5154:
URL: https://github.com/apache/nifi/pull/5154#discussion_r654806383
##########
File path:
nifi-commons/nifi-sensitive-property-provider/src/test/java/org/apache/nifi/properties/StandardSensitivePropertyProviderFactoryTest.java
##########
@@ -45,32 +48,38 @@
private static final String AD_HOC_KEY_HEX =
"123456789ABCDEFFEDCBA98765432101";
private static Path tempConfDir;
- private static Path mockBootstrapConf;
- private static Path mockNifiProperties;
+ private static Path bootstrapConf;
+ private static Path hashicorpVaultBootstrapConf;
+ private static Path nifiProperties;
private static NiFiProperties niFiProperties;
@BeforeClass
public static void initOnce() throws IOException {
Security.addProvider(new BouncyCastleProvider());
tempConfDir = Files.createTempDirectory("conf");
- mockBootstrapConf = Files.createTempFile("bootstrap",
".conf").toAbsolutePath();
+ bootstrapConf = Files.createTempFile("bootstrap",
".conf").toAbsolutePath();
+ hashicorpVaultBootstrapConf =
Files.createTempFile("bootstrap-hashicorp-vault", ".conf").toAbsolutePath();
Review comment:
This value appears to be causing failures on the Windows automated build
due to back slashes being treated as escape characters when writing out the
temporary file contents. One approach used in
`SetSingleUserCredentials.getNiFiProperties()` is Apache Commons IO
`FilenameUtils.separatorsToUnix()`, which changes separators to forward slashes
on all platforms.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
