ASF GitHub Bot commented on NIFI-2900:

Github user mcgilman commented on the issue:

    NiFi follows the semantic versioning guidelines. What your suggesting is 
changing the meaning of those fields. They are strings that are meant to be 
human-readable (one with the time and the other with the date and time). If we 
change them, we could be affecting any existing clients of that API that expect 
them to be human-readable strings. The clients I'm referring is anyone 
consuming this API in an existing version of NiFi. As you mentioned, in our 
case we would need to update the UI (which is a client of this API) to reformat 
it as necessary. This is not something we would expect others to do in a 
minor/incremental version change or without somehow versioning the API.
    As I mentioned earlier, I believe that any field using a JAXB adapter is 
currently being interpreted incorrectly by Swagger. While it would be nice if 
Swagger could correctly determine the actual data type (a string in this case 
and not a date-time) it appears they at least provide a mechanism for setting 
it explicitly. We should be taking advantage of that.

> DateTime API Endpoints don't respect RFC 3339
> ---------------------------------------------
>                 Key: NIFI-2900
>                 URL: https://issues.apache.org/jira/browse/NIFI-2900
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>    Affects Versions: 1.0.0
>            Reporter: Stephane Maarek
> Hi,
> the endpoint /flow/process-group/id is supposed to return lastRefreshed as 
> part of ProcessGroupFlowDTO as a DateTime, as indicated here:
> lastRefreshed string (date-time)      optional        The time the flow for 
> the process group was last refreshed.
> as it currently stands, what I am getting doesn't look like a timestamp:
> "lastRefreshed":"14:02:46 AEDT"
> I'm not sure how much of the overall API is affected
> Edit:
> Actually, it seems every date a "date-time" is created we expect the format 
> "HH:mm:ss z".
> As per the OpenAPI specs, if a field is annotated "date-time", it should 
> respect the RFC 3339 convention 
> (https://github.com/OAI/OpenAPI-Specification/blob/master/versions/2.0.md#data-types).

This message was sent by Atlassian JIRA

Reply via email to