szaszm commented on a change in pull request #1103:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1103#discussion_r647369353
##########
File path: extensions/libarchive/FocusArchiveEntry.cpp
##########
@@ -123,7 +121,7 @@ void FocusArchiveEntry::onTrigger(core::ProcessContext
*context, core::ProcessSe
archiveStack.push(archiveMetadata);
std::string stackStr = archiveStack.toJsonString();
-
+
Review comment:
This empty line doesn't serve a purpose: it separates closely related
lines. I think it can go altogether. Inlining `stackStr` would be even better.
##########
File path: extensions/opencv/FrameIO.h
##########
@@ -25,53 +29,51 @@ namespace minifi {
namespace opencv {
class FrameWriteCallback : public OutputStreamCallback {
- public:
- explicit FrameWriteCallback(cv::Mat image_mat, std::string image_encoding_)
- // TODO - Nghia: Check std::move(img_mat).
- : image_mat_(std::move(image_mat)), image_encoding_(image_encoding_) {
- }
- ~FrameWriteCallback() override = default;
+ public:
+ explicit FrameWriteCallback(cv::Mat image_mat, std::string image_encoding)
+ // TODO(Nghia): Check std::move(img_mat).
Review comment:
I think this TODO is outdated and can be removed. I don't see an issue
with this pass-by-value-and-move pattern involving `image_mat`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
