JonathanKessler commented on a change in pull request #5061:
URL: https://github.com/apache/nifi/pull/5061#discussion_r656171065
##########
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/SFTPTransfer.java
##########
@@ -642,6 +712,44 @@ public Socket createSocket(InetAddress inetAddress, int i,
InetAddress inetAddre
return sftpClient;
}
+ void updateConfigAlgorithms(Config config) {
+ if(ctx.getProperty(CIPHERS_ALLOWED).isSet()) {
+ Set<String> allowedCiphers =
Arrays.stream(ctx.getProperty(CIPHERS_ALLOWED).evaluateAttributeExpressions().getValue().split(","))
+ .map(String::trim)
+ .collect(Collectors.toSet());
Review comment:
I think that's unnecessary. The stream api already reduces boiler plate
and I'd need to either check if each property was set or if the returned set
was empty prior to using it to set a value.
If you were going to do something along these lines, I think a better use of
your time would be to add some CSV capabilities to the PropertyValue class
itself, allong with the StandardValidators.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
