exceptionfactory commented on a change in pull request #5098:
URL: https://github.com/apache/nifi/pull/5098#discussion_r657424889



##########
File path: 
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/ListAzureDataLakeStorage.java
##########
@@ -129,6 +131,16 @@
             
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
             .build();
 
+    public static final PropertyDescriptor TEMP_FILE_PREFIX = new 
PropertyDescriptor.Builder()
+            .name("azure-temp-file-prefix")
+            .displayName("Temp File Prefix for Azure")

Review comment:
       Thanks for following up and noting those concerns @timeabarna, I can see 
the challenge of defining complex regular expressions to filter temporary files 
and other files.  Looking at other processors, `ListSFTP` includes a Boolean 
property for `Ignored Dotted Files` as well as properties for filtering files 
and paths using regular expressions.  It seems like the question is whether it 
is necessary to support filtering both temporary files and other files.  On the 
one hand, having one filter property avoids confusion from potentially 
conflicting patterns, but on the other hand, creating the right expression 
could be challenging.
   
   @jfrazee may have a better understanding of the runtime environment, but do 
temporary files always follow a standard pattern?  If so, perhaps having a 
Boolean property for filtering temporary files would be easier to understand 
and provide the desired behavior.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to