martinzink commented on pull request #1117: URL: https://github.com/apache/nifi-minifi-cpp/pull/1117#issuecomment-867641725
You should also change the README.md Also the docker command was changed from cmake3 to cmake to accomodate for centos8 in https://github.com/apache/nifi-minifi-cpp/commit/e51192ed9639c04d69252fa033b444373173a00b which should be reverted as well I guess But one more serious issue is that https://github.com/apache/nifi-minifi-cpp/commit/6020496ad1cd2fc236815ee78b3d9f2cee640a0c changed the minimum cmake version to 3.16 and I am not sure if centos7 cmake3 is new enough to accomodate that change, if not we would have to use an alternate fix for the original issue (dropping leading zeros in project version) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
