markap14 commented on pull request #5145: URL: https://github.com/apache/nifi/pull/5145#issuecomment-868562295
I reviewed the code and did some testing. Here are my findings: - No no dependencies introduced into nifi root lib/ directory except for nifi-versioned-components-api. - NiFi Registry still starts up and works as expected. Was able to push flows, pull flows, change versions from NiFi. - Was able to push flows, pull flows, change versions when interacting with an older version of registry. Including flows that already existed and newly created/pushed flows. - Can go to localhost:18080/nifi-registry-api/swagger/ui.html and am still able to see all of the appropriate documentation, including the full documentation for VersionedProcessGroup/VersionedProcessor, etc. that I got to from the "flows" section of the API. I agree with @exceptionfactory that it makes sense to only include the swagger-annotations dependency where the nifi-registry-data-model module is used but otherwise, all looks good to me. I'm a +1 as soon as that gets updated. Thanks for pulling all this together @tpalfy - I think this is a definitely a good move in the right direction. And thanks to @exceptionfactory for the thorough review & @kevdoran for helping with the review & providing insights! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
