exceptionfactory commented on a change in pull request #5182: URL: https://github.com/apache/nifi/pull/5182#discussion_r659037746
########## File path: nifi-nar-bundles/nifi-extension-utils/nifi-event-transport/src/main/java/org/apache/nifi/event/transport/netty/StreamingNettyEventSenderFactory.java ########## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.event.transport.netty; + +import io.netty.channel.ChannelHandler; +import io.netty.handler.stream.ChunkedWriteHandler; +import org.apache.nifi.event.transport.configuration.TransportProtocol; +import org.apache.nifi.event.transport.netty.channel.LogExceptionChannelHandler; +import org.apache.nifi.event.transport.netty.codec.InputStreamMessageEncoder; +import org.apache.nifi.logging.ComponentLog; + +import java.io.InputStream; +import java.util.ArrayList; +import java.util.List; + +/** + * Netty Event Sender Factory for messages in an InputStream + */ +public class StreamingNettyEventSenderFactory extends NettyEventSenderFactory<InputStream> { + /** + * Netty Event Sender Factory with configurable character set for String encoding + * + * @param log Component Log + * @param address Remote Address + * @param port Remote Port Number + * @param protocol Channel Protocol + */ + public StreamingNettyEventSenderFactory(final ComponentLog log, final String address, final int port, final TransportProtocol protocol) { + super(address, port, protocol); + final List<ChannelHandler> handlers = new ArrayList<>(); + handlers.add(new LogExceptionChannelHandler(log)); + handlers.add(new ChunkedWriteHandler()); + handlers.add(new InputStreamMessageEncoder()); + setHandlerSupplier(() -> handlers); Review comment: Netty indicates that `ChunkedWriteHandler` is not a `@Sharable` handler, so it needs to be instantiated inside the handler supplier callback method in order for it to be created when needed. `InputStreamMessageEncoder` can be annotated with `@ChannelHandler.Sharable` since it is sharable across channels. ```suggestion final LogExceptionChannelHandler logExceptionChannelHandler = new LogExceptionChannelHandler(log); final InputStreamMessageEncoder inputStreamMessageEncoder = new InputStreamMessageEncoder(); setHandlerSupplier(() -> Arrays.asList( logExceptionChannelHandler, new ChunkedWriteHandler(), inputStreamMessageEncoder )); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
