szaszm commented on a change in pull request #1118:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1118#discussion_r659820917
##########
File path: thirdparty/pcap++/Pcap++/src/PcapLiveDevice.cpp
##########
@@ -26,11 +26,6 @@
#endif
#ifdef MAC_OS_X
#include <net/if_dl.h>
-#endif
-
-#if defined(__linux__) && !defined(__GLIBC__)
-#include <linux/sysctl.h>
-#elif !defined(WIN32) && !defined(WINx64)
#include <sys/sysctl.h>
#endif
Review comment:
It looks like we add an include `<sys/sysctl.h>` on mac, and remove all
includes on linux, because this removal makes the whole block part of `#ifdef
MAC_OS_X`. Was this your intention? Am I misunderstanding something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
