lordgamez opened a new pull request #1121: URL: https://github.com/apache/nifi-minifi-cpp/pull/1121
Issues addressed in this PR regarding integration tests: - The main problem was that the `Cluster` concept was misused in the codebase causing several issues - `Cluster` and `Container` concepts were mixed up in some places of the code which made it hard to understand it - In some test scenarios multiple clusters were created with the same network, which made the cleanup cumbersome and fail transiently - Some containers required creating new named clusters that were unnecessary and made the test scenario descriptions more complex - The `SingleNodeDockerCluster` had way too many responsibilities handling all attributes of all used docker images - There were some redundancies in the definitions of the test steps Changes made to resolve the issues: - The `SingleNodeDockerCluster` is now defined as a set of `Containers` with the same Docker network connecting them (single node referring to the original intent of running the containers on a single compute node) - All test scenarios now have a single cluster which makes the cleanup much simpler - Introducing the container concept in the code as well with the `Container` class from which all used containers are inherited from defining their own attributes, deployment functions and so on - Removing the redundancies from the step descriptions simplifies the test scenarios Jira ticket: https://issues.apache.org/jira/browse/MINIFICPP-1596 -------------------------------------------------------------------------------- Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
