adamdebreceni commented on a change in pull request #1090:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1090#discussion_r663939260
##########
File path: libminifi/test/TestBase.h
##########
@@ -445,6 +445,13 @@ class TestController {
return dir;
}
+ template<size_t N>
+ utils::Path createTempDirectory(const char (&format)[N]) {
Review comment:
if only there wasn't now three different ways to create a temporary
directory (now 2 in TestController, and 1 standalone in TestUtils.h) but I felt
like removing all the single-use `format` variables in all the tests deserves
its own PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
