[ 
https://issues.apache.org/jira/browse/NIFI-2906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15582599#comment-15582599
 ] 

ASF GitHub Bot commented on NIFI-2906:
--------------------------------------

GitHub user olegz opened a pull request:

    https://github.com/apache/nifi/pull/1144

    NIFI-2906 removed unused memebr variables

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/olegz/nifi NIFI-2906

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1144.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1144
    
----
commit 1c784a3438897c97dae71dd4237da5a449c06989
Author: Oleg Zhurakousky <o...@suitcase.io>
Date:   2016-10-17T15:54:58Z

    NIFI-2906 removed unused memebr variables

----


> Remove unused member variables from ReplaceText
> -----------------------------------------------
>
>                 Key: NIFI-2906
>                 URL: https://issues.apache.org/jira/browse/NIFI-2906
>             Project: Apache NiFi
>          Issue Type: Task
>            Reporter: Oleg Zhurakousky
>            Assignee: Oleg Zhurakousky
>            Priority: Trivial
>             Fix For: 1.1.0
>
>
> The following two member variables are not used (see line: ~213)
> {code}
> final String unsubstitutedRegex = 
> context.getProperty(SEARCH_VALUE).getValue();
>         String unsubstitutedReplacement = 
> context.getProperty(REPLACEMENT_VALUE).getValue();
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to