Lehel44 commented on a change in pull request #4948:
URL: https://github.com/apache/nifi/pull/4948#discussion_r664072770
##########
File path:
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/ScriptedTransformRecord.java
##########
@@ -17,7 +17,6 @@
Review comment:
Optional: There are some improvement opportunities in this class beyond
your modifications, feel free to pass.
1. Method extraction to reduce cognitive complexity: 158-185
2. Method extraction to reduce cognitive complexity: 187-213
3. Removing redundant array creation from the logging method towards the
bottom.
4. To throw more specific exceptions instead of Runtime exceptions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
