simonbence commented on a change in pull request #4948:
URL: https://github.com/apache/nifi/pull/4948#discussion_r664302911
##########
File path:
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/ScriptedTransformRecord.java
##########
@@ -17,7 +17,6 @@
Review comment:
- As for points 1 and 2, the same applies as above.
- For point 3> I am not sure which ones you are referring, but the ones in
lines 254, 262 and 270: the content of the array is different in every case
thus, we cannot spare them
- `RuntimeException`: in general I agree with you and it could be a good
later improvement point but as this ticket ads a bulk of new functionality I
would find it unlucky to functionally change already existing behaviour. That
easily ends up with regression issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
