Github user alopresto commented on a diff in the pull request:
    --- Diff: 
    @@ -46,23 +44,19 @@
     import javax.script.ScriptEngineManager;
     import javax.script.ScriptException;
    -import org.apache.nifi.annotation.lifecycle.OnStopped;
     import org.apache.nifi.components.AllowableValue;
     import org.apache.nifi.components.PropertyDescriptor;
     import org.apache.nifi.components.ValidationContext;
     import org.apache.nifi.components.ValidationResult;
     import org.apache.nifi.components.Validator;
    -import org.apache.nifi.processor.AbstractSessionFactoryProcessor;
     import org.apache.nifi.processor.Relationship;
     import org.apache.nifi.processor.util.StandardValidators;
     import org.apache.nifi.util.StringUtils;
    - * This class contains variables and methods common to scripting processors
    + * This class contains variables and methods common to scripting 
processors, reporting tasks, etc.
    -@Stateful(scopes = {Scope.LOCAL, Scope.CLUSTER},
    -        description = "Scripts can store and retrieve state using the 
State Management APIs. Consult the State Manager section of the Developer's 
Guide for more details.")
    -public abstract class AbstractScriptProcessor extends 
AbstractSessionFactoryProcessor {
    +public class ScriptUtils {
    --- End diff --
    I'm now realizing this is because it was previously the parent class for 
the processors. As much as it pains me to ask, I think the mental benefit of 
separating state container logic from the util methods & static constants 
outweighs the complexity of introducing a second class. Interested to hear from 
other people though; this may just be a personal preference. 

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

Reply via email to