ASF GitHub Bot commented on NIFI-1458:

Github user alopresto commented on a diff in the pull request:

    --- Diff: 
    @@ -46,23 +44,19 @@
     import javax.script.ScriptEngineManager;
     import javax.script.ScriptException;
    -import org.apache.nifi.annotation.lifecycle.OnStopped;
     import org.apache.nifi.components.AllowableValue;
     import org.apache.nifi.components.PropertyDescriptor;
     import org.apache.nifi.components.ValidationContext;
     import org.apache.nifi.components.ValidationResult;
     import org.apache.nifi.components.Validator;
    -import org.apache.nifi.processor.AbstractSessionFactoryProcessor;
     import org.apache.nifi.processor.Relationship;
     import org.apache.nifi.processor.util.StandardValidators;
     import org.apache.nifi.util.StringUtils;
    - * This class contains variables and methods common to scripting processors
    + * This class contains variables and methods common to scripting 
processors, reporting tasks, etc.
    -@Stateful(scopes = {Scope.LOCAL, Scope.CLUSTER},
    -        description = "Scripts can store and retrieve state using the 
State Management APIs. Consult the State Manager section of the Developer's 
Guide for more details.")
    -public abstract class AbstractScriptProcessor extends 
AbstractSessionFactoryProcessor {
    +public class ScriptUtils {
    --- End diff --
    I'm now realizing this is because it was previously the parent class for 
the processors. As much as it pains me to ask, I think the mental benefit of 
separating state container logic from the util methods & static constants 
outweighs the complexity of introducing a second class. Interested to hear from 
other people though; this may just be a personal preference. 

> Add scriptable ReportingTask
> ----------------------------
>                 Key: NIFI-1458
>                 URL: https://issues.apache.org/jira/browse/NIFI-1458
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Matt Burgess
>            Assignee: Matt Burgess
> Now that NIFI-210 adds scriptable Processors (and scripted onTrigger bodies), 
> a great extension would be to add a scriptable ReportingTask. This would 
> enable users to script their own ReportingTasks using the various supported 
> scripting languages.

This message was sent by Atlassian JIRA

Reply via email to