exceptionfactory commented on a change in pull request #5173:
URL: https://github.com/apache/nifi/pull/5173#discussion_r665580513



##########
File path: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutDatabaseRecord.java
##########
@@ -1476,12 +1486,14 @@ public String toString() {
         private final int dataType;
         private final boolean required;
         private final Integer columnSize;
+        private final boolean isNullable;

Review comment:
       Minor naming recommendation, but following Java Bean conventions, what 
do you think about renaming this field to `nullable`?  The accessor method 
would keep the existing name of `isNullable`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to