[
https://issues.apache.org/jira/browse/MINIFICPP-1604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marton Szasz updated MINIFICPP-1604:
------------------------------------
Description:
Due to this error on Mac / AppleClang:
[https://github.com/szaszm/nifi-minifi-cpp/runs/3024143754#step:6:14628]
It's also a warning with normal clang:
../libminifi/src/controllers/keyvalue/AbstractCoreComponentStateManagerProvider.cpp:132:23:
error: ISO C++20 considers use of overloaded operator '!=' (with operand types
'rapidjson::GenericMemberIterator<[...]>' and
'rapidjson::GenericMemberIterator<[...]>') to be ambiguous despite there being
a unique best viable function with non-reversed arguments
[-Werror,-Wambiguous-reversed-operator]
for (const auto& kv +:+ doc.GetObject()) {
../thirdparty/rapidjson-1.1.0/include/rapidjson/document.h:172:10: note:
candidate function with non-reversed arguments
bool operator!=(ConstIterator that) const
{ return ptr_ != that.ptr_; }
{color:#d1d2d3}[Tencent/rapidjson|https://github.com/Tencent/rapidjson] has
active development, but they don't seem to care about making releases. The last
release is 5 years old, but the last commit on master was just 4 days ago. I
propose and will submit a PR to upgrade to the current master, i.e.
48fbd8cd202ca54031fe799db2ad44ffa8e77c13.
{color}
{color:#d1d2d3}The [currently open known
bugs|https://github.com/Tencent/rapidjson/issues?q=is%3Aopen+is%3Aissue+label%3Abug]
are not too concerning for our uses. The parsing issues (possibly having a
security impact) have already been fixed, they just forgot to close the
tracking duplicate issues. {color}
was:
Due to this error on Mac / AppleClang:
[https://github.com/szaszm/nifi-minifi-cpp/runs/3024143754#step:6:14628]
It's also a warning with normal clang:
../libminifi/src/controllers/keyvalue/AbstractCoreComponentStateManagerProvider.cpp:132:23:
error: ISO C++20 considers use of overloaded operator '!=' (with operand types
'rapidjson::GenericMemberIterator<[...]>' and
'rapidjson::GenericMemberIterator<[...]>') to be ambiguous despite there being
a unique best viable function with non-reversed arguments
[-Werror,-Wambiguous-reversed-operator]
for (const auto& kv : doc.GetObject()) {
^
../thirdparty/rapidjson-1.1.0/include/rapidjson/document.h:172:10: note:
candidate function with non-reversed arguments
bool operator!=(ConstIterator that) const { return ptr_ != that.ptr_; }
> Upgrade rapidjson
> -----------------
>
> Key: MINIFICPP-1604
> URL: https://issues.apache.org/jira/browse/MINIFICPP-1604
> Project: Apache NiFi MiNiFi C++
> Issue Type: Improvement
> Affects Versions: 0.10.0
> Reporter: Marton Szasz
> Assignee: Marton Szasz
> Priority: Major
> Fix For: 0.11.0
>
>
> Due to this error on Mac / AppleClang:
> [https://github.com/szaszm/nifi-minifi-cpp/runs/3024143754#step:6:14628]
> It's also a warning with normal clang:
> ../libminifi/src/controllers/keyvalue/AbstractCoreComponentStateManagerProvider.cpp:132:23:
> error: ISO C++20 considers use of overloaded operator '!=' (with operand
> types 'rapidjson::GenericMemberIterator<[...]>' and
> 'rapidjson::GenericMemberIterator<[...]>') to be ambiguous despite there
> being a unique best viable function with non-reversed arguments
> [-Werror,-Wambiguous-reversed-operator]
> for (const auto& kv +:+ doc.GetObject()) {
> ../thirdparty/rapidjson-1.1.0/include/rapidjson/document.h:172:10: note:
> candidate function with non-reversed arguments
> bool operator!=(ConstIterator that) const
> { return ptr_ != that.ptr_; }
>
> {color:#d1d2d3}[Tencent/rapidjson|https://github.com/Tencent/rapidjson] has
> active development, but they don't seem to care about making releases. The
> last release is 5 years old, but the last commit on master was just 4 days
> ago. I propose and will submit a PR to upgrade to the current master, i.e.
> 48fbd8cd202ca54031fe799db2ad44ffa8e77c13.
> {color}
>
> {color:#d1d2d3}The [currently open known
> bugs|https://github.com/Tencent/rapidjson/issues?q=is%3Aopen+is%3Aissue+label%3Abug]
> are not too concerning for our uses. The parsing issues (possibly having a
> security impact) have already been fixed, they just forgot to close the
> tracking duplicate issues. {color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
