Lehel44 commented on a change in pull request #5088: URL: https://github.com/apache/nifi/pull/5088#discussion_r668292176
########## File path: nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/configuration/TrapV2cV3Configuration.java ########## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.snmp.configuration; + +public class TrapV2cV3Configuration implements TrapConfiguration { + + private final String trapOidValue; + private final int sysUpTime; + + public TrapV2cV3Configuration(final String trapOidValue, final int sysUpTime) { + this.trapOidValue = trapOidValue; + this.sysUpTime = sysUpTime; + } + + @Override + public String getTrapOidValue() { + return trapOidValue; + } + + @Override + public int getSysUpTime() { + return sysUpTime; + } + + @Override + public String getEnterpriseOid() { + throw new UnsupportedOperationException("Enterprise OID is SNMPv1 specific property."); Review comment: Avoiding the shared interface here results in duplicated methods and if-else branches. This was the best approach I could think of. We had talked about these before. From the three approaches: - Common interface with unsupported operations - Separate interfaces but downcasting and instanceof checks at every usage - Separate interfaces and branching based on the version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
