gresockj commented on a change in pull request #5210:
URL: https://github.com/apache/nifi/pull/5210#discussion_r668885621
##########
File path:
nifi-commons/nifi-record/src/test/java/org/apache/nifi/serialization/record/TestDataTypeUtils.java
##########
@@ -923,23 +939,73 @@ public void testConvertDateToUTC() {
assertEquals(0, zdt.getNano());
}
+ /**
+ * Convert String to java.sql.Date using implicit default DateFormat with
GMT Time Zone
+ *
+ * Running this method on a system with a time zone other than GMT should
return the same year-month-day
+ */
@Test
- public void testConvertDateToLocalTZ() {
- int year = 2021;
- int month = 1;
- int dayOfMonth = 25;
+ public void testConvertTypeStringToDateDefaultTimeZoneFormat() {
Review comment:
How do you feel about setting the the user.timezone system property in
some of these tests to show it working regardless of the user's time zone?
You'd have to reset the property after the test, of course. The only thing I'd
be concerned about is a multi-threaded build, but I wanted to see what you
thought.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
