emiliosetiadarma commented on a change in pull request #5202: URL: https://github.com/apache/nifi/pull/5202#discussion_r669794244
########## File path: nifi-commons/nifi-sensitive-property-provider/src/main/java/org/apache/nifi/properties/AWSSensitivePropertyProvider.java ########## @@ -0,0 +1,377 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.properties; + +import org.apache.commons.lang3.StringUtils; +import org.apache.nifi.properties.BootstrapProperties.BootstrapPropertyKey; + +import org.bouncycastle.util.encoders.Base64; +import org.bouncycastle.util.encoders.DecoderException; +import org.bouncycastle.util.encoders.EncoderException; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import software.amazon.awssdk.auth.credentials.AwsBasicCredentials; +import software.amazon.awssdk.auth.credentials.DefaultCredentialsProvider; +import software.amazon.awssdk.auth.credentials.StaticCredentialsProvider; +import software.amazon.awssdk.core.SdkBytes; +import software.amazon.awssdk.core.exception.SdkClientException; +import software.amazon.awssdk.regions.Region; +import software.amazon.awssdk.services.kms.KmsClient; +import software.amazon.awssdk.services.kms.model.DecryptRequest; +import software.amazon.awssdk.services.kms.model.DecryptResponse; +import software.amazon.awssdk.services.kms.model.DescribeKeyRequest; +import software.amazon.awssdk.services.kms.model.DescribeKeyResponse; +import software.amazon.awssdk.services.kms.model.EncryptRequest; +import software.amazon.awssdk.services.kms.model.EncryptResponse; +import software.amazon.awssdk.services.kms.model.KeyMetadata; +import software.amazon.awssdk.services.kms.model.KmsException; + +import java.io.IOException; +import java.nio.charset.Charset; +import java.nio.charset.StandardCharsets; +import java.nio.file.Paths; + +public class AWSSensitivePropertyProvider extends AbstractSensitivePropertyProvider { + private static final Logger logger = LoggerFactory.getLogger(AWSSensitivePropertyProvider.class); + + private static final String AWS_PREFIX = "aws"; + private static final String ACCESS_KEY_PROPS_NAME = "aws.access.key.id"; + private static final String SECRET_KEY_PROPS_NAME = "aws.secret.key.id"; + private static final String REGION_KEY_PROPS_NAME = "aws.region"; + private static final String KMS_KEY_PROPS_NAME = "aws.kms.key.id"; + + private static final Charset PROPERTY_CHARSET = StandardCharsets.UTF_8; + + private final BootstrapProperties awsBootstrapProperties; + private KmsClient client; + private String keyId; + + + AWSSensitivePropertyProvider(final BootstrapProperties bootstrapProperties) throws SensitivePropertyProtectionException { + super(bootstrapProperties); + // if either awsBootstrapProperties or keyId is loaded as null values, then isSupported will return false + awsBootstrapProperties = getAWSBootstrapProperties(bootstrapProperties); + if (awsBootstrapProperties != null) { + loadRequiredAWSProperties(awsBootstrapProperties); + } + } + + /** + * Initializes the KMS Client to be used for encrypt, decrypt and other interactions with AWS KMS. + * First attempts to use credentials/configuration in bootstrap-aws.conf. + * If credentials/configuration in bootstrap-aws.conf is not fully configured, + * attempt to initialize credentials using default AWS credentials/configuration chain. + * Note: This does not verify if credentials are valid. + */ + private final void initializeClient() { + if (awsBootstrapProperties == null) { + logger.warn("Cannot initialize client if awsBootstrapProperties is null"); + return; + } + final String accessKeyId = awsBootstrapProperties.getProperty(ACCESS_KEY_PROPS_NAME); + final String secretKeyId = awsBootstrapProperties.getProperty(SECRET_KEY_PROPS_NAME); + final String region = awsBootstrapProperties.getProperty(REGION_KEY_PROPS_NAME); + + if (StringUtils.isNotBlank(accessKeyId) && StringUtils.isNotBlank(secretKeyId) && StringUtils.isNotBlank(region)) { + logger.debug("Credentials/Configuration provided in bootstrap-aws.conf"); + try { + final AwsBasicCredentials credentials = AwsBasicCredentials.create(accessKeyId, secretKeyId); + client = KmsClient.builder() + .region(Region.of(region)) + .credentialsProvider(StaticCredentialsProvider.create(credentials)) + .build(); + } catch (final KmsException | NullPointerException | IllegalArgumentException e) { + final String msg = "Valid configuration/credentials are required to initialize KMS client"; + logger.error(msg); + throw new SensitivePropertyProtectionException(msg, e); + } + } else { + // attempts to initialize client with credentials provider chain + logger.debug("Credentials/Configuration not provided in bootstrap-aws.conf, attempting to use default configuration"); + try { + final DefaultCredentialsProvider credentialsProvider = DefaultCredentialsProvider.builder() + .build(); + // the following is needed to check the default credential builder, if it fails, throws SdkClientException + credentialsProvider.resolveCredentials(); + client = KmsClient.builder() + .credentialsProvider(credentialsProvider) + .build(); + } catch (final SdkClientException e) { + // this exception occurs if default credentials are not provided + final String msg = "Valid configuration/credentials are required to initialize KMS client"; + logger.error(msg); + throw new SensitivePropertyProtectionException(msg, e); + } + } + } + + /** + * Checks if the client used to communicate with AWS KMS service is open. + * @return true if the client has been initialized and open, false otherwise. + */ + private final boolean isClientOpen() { + return client != null; + } + + /** + * Validates the key ARN, credentials and configuration provided by the user. + * Note: This function performs checks on the key and indirectly also validates the credentials and + * configurations provided during the initialization of the client. + */ + private final void validate() throws KmsException, SensitivePropertyProtectionException { + if (!isClientOpen()) { + final String msg = "The AWS KMS Client failed to open, cannot validate key"; + logger.error(msg); + throw new SensitivePropertyProtectionException(msg); + } + if (StringUtils.isBlank(keyId)) { + final String msg = "The AWS KMS key provided is blank"; + logger.error(msg); + throw new SensitivePropertyProtectionException(msg); + } + + // asking for a Key Description is the best way to check whether a key is valid + // because AWS KMS accepts various formats for its keys. + + final DescribeKeyRequest request = DescribeKeyRequest.builder() + .keyId(keyId) + .build(); + + // using the KmsClient in a DescribeKey request indirectly also verifies if the credentials provided + // during the initialization of the key are valid + final DescribeKeyResponse response = client.describeKey(request); + final KeyMetadata metadata = response.keyMetadata(); + + if (!metadata.enabled()) { + final String msg = String.format("AWS KMS key [%s] is not enabled", keyId); + throw new SensitivePropertyProtectionException(msg); + } + } + + /** + * Checks if we have a key ID from AWS KMS and loads it into {@link #keyId}. Will load null if key is not present. + * Note: This function does not verify if the key is correctly formatted/valid. + * @param props the properties representing bootstrap-aws.conf + */ + private void loadRequiredAWSProperties(final BootstrapProperties props) { + if (props != null) { + keyId = props.getProperty(KMS_KEY_PROPS_NAME); + } + } + + + /** + * Checks bootstrap.conf to check if BootstrapPropertyKey.AWS_KMS_SENSITIVE_PROPERTY_PROVIDER_CONF property is + * configured to the bootstrap-aws.conf file. Also will try to load bootstrap-aws.conf to {@link #awsBootstrapProperties}. + * @param bootstrapProperties BootstrapProperties object corresponding to bootstrap.conf. + * @return BootstrapProperties object corresponding to bootstrap-aws.conf, null otherwise. + */ + private BootstrapProperties getAWSBootstrapProperties(final BootstrapProperties bootstrapProperties) { + if (bootstrapProperties == null) { + logger.warn("The file bootstrap.conf provided to AWS SPP is null"); + return null; + } + + final BootstrapProperties cloudBootstrapProperties; + + // Load the bootstrap-aws.conf file based on path specified in + // "nifi.bootstrap.protection.aws.kms.conf" property of bootstrap.conf + final String filePath = bootstrapProperties.getProperty(BootstrapPropertyKey.AWS_KMS_SENSITIVE_PROPERTY_PROVIDER_CONF).orElse(null); + if (StringUtils.isBlank(filePath)) { + logger.warn("File Path to bootstrap-aws.conf in bootstrap.conf is blank"); Review comment: Making the changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
