fgerlits commented on a change in pull request #1129:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1129#discussion_r670532424
##########
File path:
libminifi/src/controllers/keyvalue/AbstractCoreComponentStateManagerProvider.cpp
##########
@@ -24,6 +24,10 @@
#include "rapidjson/stringbuffer.h"
#include "rapidjson/writer.h"
+#ifdef GetObject
+#undef GetObject
+#endif /* GetObject -> GetObject[AW] on windows */
Review comment:
I don't think we need the `#ifdef`; also I would include a comment
everywhere, not just here.
```suggestion
// windows.h #defines GetObject = GetObjectA or GetObjectW, which conflicts
with rapidjson
#undef GetObject
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
