fgerlits commented on a change in pull request #1110:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1110#discussion_r671306945
##########
File path: CMakeLists.txt
##########
@@ -503,6 +517,8 @@ endif()
## OpenCV Extensions
option(ENABLE_OPENCV "Disables the OpenCV extensions." OFF)
if (ENABLE_OPENCV)
+ include(BundledOpenCV)
+ use_bundled_opencv(${CMAKE_CURRENT_SOURCE_DIR}
${CMAKE_CURRENT_BINARY_DIR})
createExtension(OPENCV-EXTENSIONS "OPENCV EXTENSIONS" "This enabled
OpenCV support" "extensions/opencv" "extensions/opencv/tests")
Review comment:
```suggestion
createExtension(OPENCV-EXTENSIONS "OPENCV EXTENSIONS" "This enables
OpenCV support" "extensions/opencv" "extensions/opencv/tests")
```
##########
File path: CMakeLists.txt
##########
@@ -503,6 +517,8 @@ endif()
## OpenCV Extensions
option(ENABLE_OPENCV "Disables the OpenCV extensions." OFF)
Review comment:
Old stuff and not important, but this should be "Enables ..."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
