szaszm commented on a change in pull request #1134:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1134#discussion_r673292444
##########
File path: thirdparty/pybind11/include/pybind11/attr.h
##########
@@ -12,7 +12,7 @@
#include "cast.h"
-NAMESPACE_BEGIN(PYBIND11_NAMESPACE)
+PYBIND11_NAMESPACE_BEGIN(PYBIND11_NAMESPACE)
Review comment:
What do you think about FetchContent? I prefer it over ExternalProject,
because ExternalProject downloads sources during build while FetchContent does
it during configure, which means if you're using an IDE, headers may not be
present and include paths may be broken before the first build. It also results
in simpler cmake code IMO.
Done in a2ac1f3, but I couldn't reuse pybind11's own cmake files. They look
reasonable, but I just kept getting linker errors that I was unable to solve.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
