timeabarna commented on a change in pull request #5098:
URL: https://github.com/apache/nifi/pull/5098#discussion_r675387450
##########
File path:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/ListAzureDataLakeStorage.java
##########
@@ -226,9 +239,12 @@ protected String getPath(ProcessContext context) {
options.setRecursive(recurseSubdirectories);
Pattern baseDirectoryPattern = Pattern.compile("^" + baseDirectory
+ "/?");
+ final String tempFilePrefix =
defaultIfBlank(System.getProperty("tempFilePrefix"), TEMP_FILE_PREFIX);
Review comment:
@jfrazee @exceptionfactory Let me summarise my understanding on your
recommendations as it seems that the final solution would be a mix of the old
things :)
List processor:
- Modify listing to hide any file and folder which names starting with
either _ or .
- Keep the boolean property which is turning on the filtering of the above
Put processor:
- Create a property for tempfolder .
- Modify rename to put the temp file in the provided tempfolder under a
generated UUID with the existing file name
My questions:
1. As renaming will be location related not name related, is this still
atomic?
2. Should tempfolder property used as name only, location only or both? This
requires different validation.
3. What happens if a Customer would like to use Put processor as in PutHDFS,
which is putting the temp file in the same directory as the file is located,
using . + filename as naming? Should we allow this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
