gresockj commented on a change in pull request #5193:
URL: https://github.com/apache/nifi/pull/5193#discussion_r675468366
##########
File path:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service-api/src/main/java/org/apache/nifi/elasticsearch/IndexOperationRequest.java
##########
@@ -25,11 +25,11 @@
* covers all CRUD-related operations that can be executed against an
Elasticsearch index with documents.
*/
public class IndexOperationRequest {
- private String index;
- private String type;
- private String id;
- private Map<String, Object> fields;
- private Operation operation;
+ private final String index;
+ private final String type;
+ private final String id;
+ private final Map<String, Object> fields;
+ private final Operation operation;
public IndexOperationRequest(String index, String type, String id,
Map<String, Object> fields, Operation operation) {
Review comment:
Perhaps also a good time to make these parameters final.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
