Github user jvwing commented on the issue:
    I have a few more comments from running the processor and reviewing the 
    **Processor Annotations**
    * The CapabilityDescription says this processor transfers one flowfile for 
each sheet in the Excel document, but that was not my experience.  It 
aggregated all content into one output flowfile.  Is that the intended behavior?
    * Most NiFi attribute names are lowercase, "sheetname" or "" 
instead of "SheetName".  I don't believe there is a hard and fast rule there, 
but I recommend going lowercase if you do not have a strong preference.
    * PropertyDescriptors should have `name` as a machine readable key like 
"extract-sheets" and `displayName` for the user "Sheets to Extract".
    **Exception Handling and Logging**
    Most NiFi components use `getLogger().error(...` as you do later in the 
code, rather than `printStackTrace()`.  I haven't tested these error cases, but 
they appear to be informational rather than stopping or failing the flow.  
Would `getLogger().info(...` or `getLogger().debug(...` be a better fit here?  
Do users need the full stack trace, or would just the message be helpful enough?
    } catch (InvalidFormatException e) {
    } catch (OpenXML4JException e) {
    } catch (SAXException e) {

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

Reply via email to